-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Error: Expected a valid key to convert, with length 1, 2, 4, 8, 32, 33 #157
Comments
…ludes evm accounts
Oh, i just realised that i'd created this same issue before here #69 Is this an appropriate temporary solution? |
@ltfschoen could you provide more info on can you import an EVM address (e.g. for Moonbeam) into Polkadot.js Extension? |
yes, it is possible to import an EVM address that you use across multiple EVM chain accounts, such as Moonbeam, Ethereum, etc. |
Hei @ltfschoen could you send a video of how to import this account into polkadot js. |
it shows how to do it at 2 mins into this video (I'm not the presenter) https://youtu.be/9ohp8k4Hz8c?feature=shared the videos are published in the wiki https://guide.kusama.network/docs/learn-guides-accounts/ |
So @poppyseedDev I managed to break the app and replicate @ltfschoen's issue Reproduce:
and 🎉 |
Nice thanks @vikiival! Okay, let's then fix this. |
fix: Fixes #157 prevent crash if polkadot.js ext includes evm acct
Describe the bug
If I connect with Polkadot.js Extension and one of the accounts is an EVM account (i.e. 0x____) instead of a Substrate SS58 address then it crashes with browse console error
Error: Expected a valid key to convert, with length 1, 2, 4, 8, 32, 33
unless I know to hide that specific address within Polkadot.js ExtensionTo Reproduce
Steps to reproduce the behavior:
Expected behavior
It should try/catch and ignore that EVM wallet instead of crashing
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Note
Once you take on this PR paste a comment with your hand -> ✋ so that people know that someone is working on this issue.
The text was updated successfully, but these errors were encountered: