Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix step idx logging and eval frequency #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ntoxeg
Copy link

@ntoxeg ntoxeg commented Jun 12, 2024

Step index is incorrectly logged as a metric, it should be passed as the step keyword argument to logger.log, otherwise the logger (W&B, etc.) will just assume 1:1 indexing. This is a problem for anyone using logging frequency different than 1.

Additionally, I’ve changed eval logic to only proc if the step index is divisible by 10, so that eval doesn’t run on every step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant