allow user to choose locale and timezone #5844
Merged
+19
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Users could not choose locale, were forced to use iso format and could not set a custom format
AFTER - What is happening after this PR?
Users have the option of locale, though it still defaults to the app locale or can use an entirely custom format
HOW
How did you achieve that, in technical terms?
You can set the locale on the column or you can set a closure for a format to do it entirely custom. You can have it set a timezone or return a diff instead of a time itself
Is it a breaking change?
No
How can we test the before & after?
You can set a format custom function. I set a column like this:
CRUD::column('created_at')->format(fn($date) => $date->timezone('America/New_York')->toDateTimeString());If the PR has changes in multiple repos please provide the command to checkout all branches, eg.: