fix page lenght stalling in cache & colspan issue on the table #5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
reported in #4951
When the
showEntryCountwas false, and thelengthof the page was smaller than the showed entries, a bug would appear because we set the filtered rows to 0, making the table behave as if it had 0 entries on it.Related to that, while testing I found out that the
pageLengthcould stall in the datatable cache in certain conditions.AFTER - What is happening after this PR?
No more issues with the "empty table" state and the pageLength is not stall anymore.
HOW
How did you achieve that, in technical terms?
Set the
filteredCountto the actual count in the table and added a check for pageLength cache.Is it a breaking change?
no