Allow customization of reorder column names #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
fixes: Laravel-Backpack/community-forum#13
BEFORE - What was wrong? What was happening before this PR?
It wasn't possible to customize the columns used by the reorder operation.
AFTER - What is happening after this PR?
Using an operation setting
reorderColumnNames, developer can now customize the column names used in the reorder operation.HOW
How did you achieve that, in technical terms?
Introduced a setting that hold the column names for the reorder operation. The whole operation use those column names provided by developer.
Is it a breaking change?
No, the "old" columns are the default.