Use widgets as a way to build details row #5655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Suggested in Laravel-Backpack/community-forum#712
We could get creative with details row by allowing developers to add widgets there instead of just providing a way to overwrite the view.
At the moment, the only way to have a view, and pass additional control data was to:
showDetailsRow($id)method.In 10 controllers it gets cumbersome to have to overwrite the method in all of them to add some
['data' => 'my info']to all of them.AFTER - What is happening after this PR?
You can simply build a widget (a view for your details row), and pass any additional information on the widget directly instead of having to overwrite the method.
HOW
How did you achieve that, in technical terms?
Just added a
@include()widgets view, and pull the widgets from thedetails_rowsection.Is it a breaking change?
No.