Fix mobile icons - folder path #5607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karandatwani92
changed the title
|
Thanks @karandatwani92 I can see the issue you mentioned. I think we can have a simpler solution, how about Cheers |
pxpm
force-pushed
the
fix-save-to-mobile-folder-path
branch
from
9f403b8
to
1c8acf5
Compare
|
@pxpm Thanks. I was testing your solution when you just merged. It's working without any issues. Cheers 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
While writing an article on this feature, I found a BUG.
BEFORE - What was wrong? What was happening before this PR?
if icons were published to a sub-folder, Icon paths were incorrect for the following stubs:
browserconfig.stubmanifest.stubHOW
How did you achieve that, in technical terms?
Just prepend a forward slash '/' if publishing to a sub-folder.
Is it a breaking change?
NO