Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add check_format parameter to LLS argument to restore json output #6977

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Feb 6, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

With recent LLS changes, the default output format was changed in cases where a new parameter (check_format) was added, and we do not explicitly set check_out_path (see: LuaLS/lua-language-server#3051)

Adds check_format parameter to LLS call in CI to move back to json output and fixes CI failures.

Steps to test these changes

CI should not fail on non-existing file.

@LandSandBoat LandSandBoat deleted a comment from github-actions bot Feb 6, 2025
@claywar claywar merged commit 6859960 into base Feb 6, 2025
13 of 14 checks passed
@claywar claywar deleted the ci/set-lls-format branch February 6, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants