Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] remove duplicate code for Eldieme Necropolis candles #6900

Open
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

Grahf0085
Copy link
Contributor

@Grahf0085 Grahf0085 commented Jan 30, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Removes duplicate code for lighting the candles in Eldieme Necropolis. Code is rafactored into one function that lives in globals.lua and called by each candle NPC. The candles are sued to spawn seven different NMs. If this PR goes through there's a couple issues with the lamps I'd like to address next. Such as no fire animation when the lamp is lit, when checking a lit lamp it tells you it's unlit, etc

Steps to test these changes

Trade a flintstone to the lamps. Should behave the same as it always has. Will tell you the lamp is lit and how many of the seven lamps are left to lite. After lighting all seven a NM will spawn at each lamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant