[lua] remove duplicate code for Eldieme Necropolis candles #6900
+83
−190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Removes duplicate code for lighting the candles in Eldieme Necropolis. Code is rafactored into one function that lives in globals.lua and called by each candle NPC. The candles are sued to spawn seven different NMs. If this PR goes through there's a couple issues with the lamps I'd like to address next. Such as no fire animation when the lamp is lit, when checking a lit lamp it tells you it's unlit, etc
Steps to test these changes
Trade a flintstone to the lamps. Should behave the same as it always has. Will tell you the lamp is lit and how many of the seven lamps are left to lite. After lighting all seven a NM will spawn at each lamp.