Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] BST mobs pets despawn if not aggresive on master death #6896

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

sruon
Copy link
Contributor

@sruon sruon commented Jan 30, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Attaches listeners on mobskill "Call Beast" usage, ensuring their pet gets despawned if not aggressive at the time of master death/despawn. See retail example

This ensures pets are not "orphaned" if the master was killed in one hit or despawned due to other conditions (Fomor Beastmaster in Wajaom disappearing during the day, for example)

Steps to test these changes

https://www.youtube.com/watch?v=RJwZFLgiVFs

  • Aggro a BST mob and kill it, pet should not despawn
  • One shot or !despawnmob a BST mob, the pet should despawn

When a BST mob dies or despawn, their pet will be despawned if they are not engaged in combat, matching retail behavior.
Copy link
Member

@WinterSolstice8 WinterSolstice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough

@zach2good zach2good merged commit 53efd71 into LandSandBoat:base Feb 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants