Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Audit mob droplist - 31 to 60 #6891

Open
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

LacunaXI
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Continues the work outlined in #6756.

Highlights for the first time in these PRs are Nyzul and Beastmen. Vigil Weapons and ??? items are handled in nyzul.lua. These Nyzul SQL drops result in incorrect (unappraisable?) ??? items as well as duplicate drops of vigil weapons. At the same time these dropids are not wasted as the same foes are lacking their ordinary drops which are being added.

Beastmen throughout the sql have incorrect drops and extras they shouldn't or frequently have the same drops and rates across zones. Dungeon beastmen drop equipment but Beastmen in the field do not. In the future you will continue to see Beastmen moving around the file or being merged and their dropid made available. The armor from these Beastmen begins at an ungrouped Very Rare, 1% and quickly becomes rarer as the level of the equipment increases.

Steps to test these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants