Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assault] Warhorse Hoofprints #6879

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

KnowOne134
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

adds random warhorse hoofprints into toau zones for promotion quests.
Picks a zone to spawn on start and finds a random point from table to spawn.
Over time it can spawn more in other zones and despawn already up points in other times
adds correct sql data for points -- missing correct look, era no look is still in effect.

will make a followup pr for correct look
adding default dialog in followup pr for rank quest.

Steps to test these changes

startup map
search for warhorse hoofprints in the 4 zones they can spawn

* Add SP promotion quest and hoofprint logic

* Remove unnecessary 0s

* Remove print

* Add text_table fix

* Check if hoofprint is visible before removing

* Improve logic for adding hoofprints
@KnowOne134 KnowOne134 force-pushed the hoof_prints branch 3 times, most recently from e952955 to 73a8dc5 Compare January 29, 2025 03:51
@Xaver-DaRed
Copy link
Contributor

Overall looks very good. Just one minor nitpick from my end: Could we have the npc entries added to the IDs.lua files in alphabetical order?

@KnowOne134
Copy link
Contributor Author

Overall looks very good. Just one minor nitpick from my end: Could we have the npc entries added to the IDs.lua files in alphabetical order?

got ya, had it that way while i was at work, forgot to push to finish at home. Then had to redo it by memory while kicking myself for forgetting.

@claywar claywar merged commit e039aea into LandSandBoat:base Feb 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants