Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Tidy SQL usage in login, search, and world servers #6876

Open
wants to merge 5 commits into
base: base
Choose a base branch
from

Conversation

zach2good
Copy link
Contributor

@zach2good zach2good commented Jan 28, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Also tidies multiline strings

Testing:

  • Make a new character
  • Change password
  • Delete a character
  • Log in
  • /sea all
  • Send tell
  • Join party
  • Send party chat
  • Add someone to blacklist
  • Create and name a linkshell
  • Make a linkpearl and trade to someone else
  • Both equip linkpearls
  • Send linkshell chat - seen by all
  • List something on the AH
  • Buy something on the AH - get item
  • De-list something from the AH
  • AH: Price history shows
  • AH: Current listings show
  • AH: Listing per-item show
  • AH: Have someone buy something - gil shows up in dbox
  • Send something to another char in the dbox
  • Get something from another char in the dbox
  • Daily tally
  • Conquest
  • Cancel dbox sends

@zach2good zach2good force-pushed the tidy_queries_login_search_world branch 12 times, most recently from e78be60 to 2ba744b Compare January 30, 2025 11:51
@zach2good zach2good force-pushed the tidy_queries_login_search_world branch from 2ba744b to b65e115 Compare January 30, 2025 12:38
@zach2good zach2good force-pushed the tidy_queries_login_search_world branch 3 times, most recently from 2778b78 to dd12847 Compare January 30, 2025 13:55
@zach2good zach2good force-pushed the tidy_queries_login_search_world branch 3 times, most recently from 9c9ee97 to adbf6be Compare January 30, 2025 16:18
@zach2good zach2good force-pushed the tidy_queries_login_search_world branch from adbf6be to 04e43b7 Compare January 30, 2025 18:53
@zach2good zach2good force-pushed the tidy_queries_login_search_world branch from d05c5ea to 7a1c338 Compare January 30, 2025 20:11
@zach2good zach2good force-pushed the tidy_queries_login_search_world branch from 5483fcb to 9bb1f38 Compare January 30, 2025 22:20
@zach2good zach2good added the hold On hold, pending further action/info label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold On hold, pending further action/info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants