Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Castle Zvahl Teleporters #6861

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

dallano
Copy link
Contributor

@dallano dallano commented Jan 27, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds retail accurate functionality to the telepads in Castle Zvahl Keep
  • Achieved by running each telepad on an individual timer between 20-50 seconds as witnessed in linked capture. A table was created that ties each npc ID with the appropriate event ID and trigger area. Whenever that portal is opened on its cooldown, the appropriate trigger area checks if said portal is open to allow the player to travel through.
  • Implemented an auto-teleport feature that is also evident in retail: The player is automatically teleported if already standing on the telepad. This is achieved by setting a variable on the player. When a portal is triggered it searches for players with the appropriate variable set. If such a player is discovered, the appropriate event is called to teleport them automatically. This variable is unset when player leaves trigger zone.

Captures: https://1drv.ms/f/s!AtUZibtOtozEhoBMroc6yCCkVgliXg?e=bhhaKF

Steps to test these changes

Walk into a portal if it appears open, and be teleported to the appropriate location
Walk into a portal if it appears closed
Stand in closed portal and wait for it to open and be teleported without having to re-enter the platform

@dallano dallano force-pushed the GEN_zvhalTeleporters branch from 96db82e to 01b689c Compare January 27, 2025 02:31
- Adds retail accurate functionality to the telepads in Castle Zvahl Keep
- Achieved by running each telepad on an individual timer between 20-50 seconds as witnessed in linked capture
- Implemented an auto-teleport feature that is also evident in retail: The player is automatically teleported if already standing on the telepad. This is achieved by setting a variable on the player. When a portal is triggered it searches for players with the apropriate variable set. If so, teleport them through. This variable is unset when player leaves trigger zone.

Styling error fix

Style error fix of " -> ' around string variable name

Fix improper events

Fixed incorrect ID calls to telepads
@dallano dallano force-pushed the GEN_zvhalTeleporters branch from 01b689c to 82650d4 Compare January 27, 2025 04:50
@zach2good zach2good merged commit dda6520 into LandSandBoat:base Jan 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants