Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty NPC functions, add Default Actions - Abdhaljs ~ Buburimu #6857

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Jan 26, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Final followup to #6742

  • Removes empty function definitions from NPCs in zones Caedarva Mire ~ Kamihr Drifts
  • If applicable, moves default actions to defaultActions script for each zone
  • If result of above change is an empty file, remove file

Total results from initial for all related PRs drops us to a bit under 49.2MB usage in Lua cache. Resulting cleanup numbers for code changes is:
image

Steps to test these changes

No impact to gameplay, default actions should still be displayed

@claywar claywar merged commit 28ad9bc into base Jan 27, 2025
14 checks passed
@claywar claywar deleted the empty-npcs-b branch January 27, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants