Add additional safety, logging to CLuaBaseEntity bindings #6629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Searches existing code in lua_baseentity.cpp for
static_cast<CBattleEntity*>
and audits existing code for appropriate checks, since NPCs can potentially call these functions and cause failures.If NPC check is currently existing, code is not modified, but if no check exists, it converts to dynamic_cast. In some cases, types were modified to reflect the expected function (ex: CCharEntity* being passed into CBattleEntity* parameter)
Steps to test these changes
Check expected result from valid target(s), attempt to call function on NPC to see error messaging and no crash