-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Lay out casts and null checks more around gardening #4282
Conversation
ea4a30d
to
0ab19c2
Compare
bool ignoredDuringStage = !wasExamined && stageDuration > wiltTime; | ||
bool ignoredSinceChange = !wasExamined && stageDuration + daysSinceStageChange > wiltTime; | ||
bool shouldForceWilt = daysSinceStageChange > VANADAYS_TO_GUARANTEE_WILT + wiltTime; | ||
|
||
if (ignoredDuringStage || ignoredSinceChange || shouldForceWilt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this logical split to downstream and they are currently testing it to see if one of these is redundant and possibly causing spurious wilting
I'm going to be pretty busy this week, if someone could quickly smoke test this against a day or two of gardening it would be much appreciated |
I made a fresh build of your branch. Maybe I'm doing something wrong, however, after placing the flowerpots, when attempting to feed it a seed to grow it, it will just ignore the imput. Won't consume the seed and the flowerpot will remain empty. This happens with all 10 placed flowerpots. |
I was hoping Horizon would have made some similar changes to this and had some feedback, but they haven't had time/bandwidth, and I don't know gardening well enough to weigh in on anything apart from how C++ works. Closing, pending more reports/info |
* update promotion lance corporal * fix capitalization of vars.Stage
* Lance Corp start files * update promotion lance corporal (#4282) --------- Co-authored-by: Duke <109076646+Dukilles@users.noreply.github.com>
I affirm:
What does this pull request do?
Steps to test these changes