[WIP][Nyzul] Rewrite Nyzul Isle Investigation #4190
Draft
+2,387
−2,471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaver-DaRed
force-pushed
the
Nyzul/Rewrite
branch
from
bf279bd to
1ec9398
Compare
Xaver-DaRed
force-pushed
the
Nyzul/Rewrite
branch
from
8728295 to
fe9d6e5
Compare
|
If you need help testing anything, I'm willing to help out. I was getting ready to tackle this myself for our server. Some things of note with the current implementation and the client crash when entering the instance. The client crash can be avoided if you are in the menu when instance leader/initiator confirms entry. |
|
Once it's ready, feel free to cherry-pick and test it. The more ppl helping testing it, the better. |
Xaver-DaRed
force-pushed
the
Nyzul/Rewrite
branch
from
ec35c9d to
b09a468
Compare
|
When this is eventually ready for review, I think you're going to have to write a little review guide so we know where to look, because this is massive :D |
Xaver-DaRed
force-pushed
the
Nyzul/Rewrite
branch
from
ad4afa5 to
1c1d8f7
Compare
Xaver-DaRed
force-pushed
the
Nyzul/Rewrite
branch
6 times, most recently
from
bdbc8ed to
e5e918e
Compare
- Remove pathos logic and tables from nyzul global. - Create global functions for gear mobs engage and death. - Cleanup mob scripts and family mixin. - Adjust pets.lua pathos lookup in case it gets changed.
- Renamed table names. - Addopted a "first mob, last mob" pattern across all tables. - Changed logic to reflect this changes. - Renamed how dynamic tables are named, so we can now they are crated and edited on the spot. - Changed how rates are handled, to make them clearer.
- Rename "NII_pathos" to "pathos". We are inside a folder, we dont need the NII_ subfix anymore. - Rename addFloorPathos to addPathos
- Move logic from instance file to "floor_generation" - Move data from nyzul global AND points file to "floor_generation" - Adjust spawn point data to simplify logic
- Delete points file entirely. - Delete references to said file. - Cleanup logic for lamp positioning
- Cleanup and comenting mostly. - Left a couple of TODOs in there
Xaver-DaRed
force-pushed
the
Nyzul/Rewrite
branch
from
f9274a7 to
6bc8489
Compare
Xaver-DaRed
force-pushed
the
Nyzul/Rewrite
branch
from
6bc8489 to
76d67c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Originally intended to contain all the rewrite, it became obvious it was far too large and far too complex to be reviewed in a sane manner.
So now, this PR will act as a guide for the smaller PRs that will be opened containing small chunks of the rewrite at a time, to, hopefully, make it simpler to review and to code without having to rebase multiple times.
It will also act as the final PR of the rewrite, couse I already opened it and why clutter the PR history?
Steps to test these changes
Half of it it's already in, so... Do nyzul and see if it works, I guess, I dunnow. What's nyzul?