Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control of the default environment name #1

Open
stuartleeks opened this issue Sep 28, 2016 · 4 comments
Open

Allow control of the default environment name #1

stuartleeks opened this issue Sep 28, 2016 · 4 comments

Comments

@stuartleeks
Copy link

As per the marketplace instructions,

The environment will affect the Dockerfile that is used during build. If you select Debug, the build task will search for Dockerfile, otherwise it will search for Dockerfile.<environment>.

It would be really helpful to be able to specify which environment is default. E.g. if I set release to the default environment then when the environment is set to release it would use Dockerfile, and for any other environment it would use Dockerfile.

The default value for the default environment could be "debug" to preserve existing behaviour unless someone explicitly changes it

@giggio
Copy link
Contributor

giggio commented Sep 28, 2016

@stuartleeks Right now Debug is the default. What would you like to see changed?

@stuartleeks
Copy link
Author

I'd like to be able to customise the default value :-)

E.g. I'd like to be able to have the Release environment use Dockerfile, and the Debug environment user Dockerfile.debug

Does that make sense?

stuartleeks added a commit to stuartleeks/vsts-build-task-docker that referenced this issue Sep 29, 2016
@giggio
Copy link
Contributor

giggio commented Oct 6, 2016

Yes, it does. The reason I did not do that, is that the syntax highlighting (and other tools support) usually stops working with the .debug or .release extension. I saw you send a PR, I will check it out now.

@stuartleeks
Copy link
Author

I use Visual Studio Code for a lot of Dockerfile editing and it is well-behaved with Dockerfile.something filenames, so I just assumed others were too :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants