Fix: Added fix for rate_limit_delay attribute error, resolved async wait #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabosom
approved these changes
Feb 4, 2025
| for component in PLATFORMS: | ||
| await hass.config_entries.async_forward_entry_setup(entry, component) | ||
| # Resolve deprecation in latest HA by moving to setups vs setup | ||
| await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS) |
gabosom
approved these changes
Feb 4, 2025
gabosom
suggested changes
Feb 5, 2025
| @@ -99,7 +99,7 @@ def _unload_component_entry( | |||
| """Unload an entry for a specific component.""" | |||
| success = False | |||
| try: | |||
| success = hass.config_entries.async_forward_entry_unload(entry, component) | |||
| success = await hass.config_entries.async_forward_entry_unload(entry, component) | |||
There was a problem hiding this comment.
this will fail, the function needs to be defined as async
There was a problem hiding this comment.
I tried the changes manually and they seem to work but this PR making the line 96 function definition async.
There was a problem hiding this comment.
@gabosom odd, I could have sworn I tried that and still got errors. So did you set the def as a sync and keep the await?
I can give that another test and update the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the errors with the
rate_limit_delayfunction, as well as subsequent async related errors that happen afterwards.Resolves: #216