Everywhere: Enable more libraries in Windows CI - #5188
Merged
ADKaster merged 11 commits intoJun 27, 2025
Conversation
This was referenced Jun 24, 2025
ayeteadoe
changed the title
ayeteadoe
marked this pull request as draft
June 24, 2025 10:16
R-Goc
reviewed
Jun 24, 2025
ayeteadoe
force-pushed
the
windows-enable-libgfx
branch
from
June 24, 2025 16:27
37a7669 to
decb9b6
Compare
ayeteadoe
commented
Jun 24, 2025
ayeteadoe
force-pushed
the
windows-enable-libgfx
branch
3 times, most recently
from
June 24, 2025 17:40
8028011 to
005bc08
Compare
ADKaster
reviewed
Jun 24, 2025
R-Goc
reviewed
Jun 24, 2025
ADKaster
reviewed
Jun 24, 2025
ayeteadoe
force-pushed
the
windows-enable-libgfx
branch
from
June 24, 2025 19:59
005bc08 to
0855bcf
Compare
Contributor
Author
|
My initial angle patches have fixed the configure errors and resolved a few linker errors. Just a few left to address |
ayeteadoe
force-pushed
the
windows-enable-libgfx
branch
from
June 24, 2025 20:01
0855bcf to
b064cd3
Compare
Contributor
Author
|
I'm going to split out getting LibWeb and the remaining tasks dependent on that into their own PR, several libs are good to go here and no sense delaying them on this Angle shenangians |
ayeteadoe
force-pushed
the
windows-enable-libgfx
branch
from
June 25, 2025 01:05
b064cd3 to
c3b2a79
Compare
ayeteadoe
marked this pull request as ready for review
June 25, 2025 01:06
ADKaster
reviewed
Jun 26, 2025
ayeteadoe
force-pushed
the
windows-enable-libgfx
branch
2 times, most recently
from
June 26, 2025 16:01
9bfb250 to
3d9ccd5
Compare
1 task
ayeteadoe
force-pushed
the
windows-enable-libgfx
branch
from
June 26, 2025 16:25
3d9ccd5 to
9180eb4
Compare
ADKaster
reviewed
Jun 26, 2025
We need some msvc-only cusotmization here to get LibGfx building
The libjxl port is required to add the `msvc-remove-libm` patch. Otherwise LibGfx attempts to link with 'm.lib' which is not valid for MSVC as the CRT bundles math functions implicitly unlike on Unix
All the file-based tests left out build, but they all fail at run time with the error "No such file or directory" or a Core::File-based assertion failure for the Benchmark test
ayeteadoe
force-pushed
the
windows-enable-libgfx
branch
from
June 26, 2025 17:16
9180eb4 to
0b14620
Compare
ADKaster
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tackles a bunch of low hanging fruit wrt getting libraries built and tests passing that require little to no modification.