LibWeb: Make :open target color and file inputs with an open picker
#3419
+112
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
github-actions
bot
added
the
conflicts
AtkinsSJ
force-pushed
the
css-open-pseudoclass
branch
from
6d24844 to
198ad55
Compare
|
Fixed conflicts. |
github-actions
bot
removed
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works when testing it manually, but I can't seem to figure out how to make an automated test for it unfortunately.
I've imported the existing WPT test for
:openbut it doesn't cover<input>, and possibly never will as the behaviour of different input types is largely UA-defined. We fail the subtest for<select>too, and that also works when done manually.