LibWeb/HTML: Scroll to the fragment before loading the document #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonbooth
force-pushed
the
scroll-to-fragment-before-document-load
branch
from
f4cf6c4 to
8bed2ad
Compare
shannonbooth
force-pushed
the
scroll-to-fragment-before-document-load
branch
from
8bed2ad to
e3bb4b4
Compare
gmta
reviewed
Jan 15, 2025
shannonbooth
force-pushed
the
scroll-to-fragment-before-document-load
branch
from
e3bb4b4 to
5cb91d4
Compare
Otherwise nowhere ends up scrolling to the fragment specified by the fragment in document's URL. This fixes ladybird scrolling to the correct location in the document when navigating to a link that has a fragment, e.g: https://html.spec.whatwg.org/multipage/browsing-the-web.html#try-to-scroll-to-the-fragment As well as use of the :target selector.
shannonbooth
force-pushed
the
scroll-to-fragment-before-document-load
branch
from
5cb91d4 to
07d3197
Compare
AtkinsSJ
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise nowhere ends up scrolling to the fragment specified by the
fragment in document's URL. This fixes ladybird scrolling to the
correct location in the document when navigating to a link that
has a fragment, e.g:
https://html.spec.whatwg.org/multipage/browsing-the-web.html#try-to-scroll-to-the-fragment
As well as use of the :target selector.