LibWeb: Mark a few calls to set_attribute as infallible

These cannot possibly throw an exception because the attribute names are already known to be valid.
LadybirdBrowser · Jan 15, 2025 · e95096d · e95096d
1 parent b43bb24
commit e95096d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Libraries/LibWeb/HTML/HTMLLIElement.h b/Libraries/LibWeb/HTML/HTMLLIElement.h
@@ -38,7 +38,7 @@ class HTMLLIElement final : public HTMLElement {
     WebIDL::Long value();
     void set_value(WebIDL::Long value)
     {
-        set_attribute(AttributeNames::value, String::number(value)).release_value_but_fixme_should_propagate_errors();
+        MUST(set_attribute(AttributeNames::value, String::number(value)));
     }
 
 private:

diff --git a/Libraries/LibWeb/HTML/HTMLOListElement.h b/Libraries/LibWeb/HTML/HTMLOListElement.h
@@ -25,7 +25,7 @@ class HTMLOListElement final : public HTMLElement {
     WebIDL::Long start();
     void set_start(WebIDL::Long start)
     {
-        set_attribute(AttributeNames::start, String::number(start)).release_value_but_fixme_should_propagate_errors();
+        MUST(set_attribute(AttributeNames::start, String::number(start)));
     }
 
 private:

diff --git a/Libraries/LibWeb/HTML/HTMLSummaryElement.cpp b/Libraries/LibWeb/HTML/HTMLSummaryElement.cpp
@@ -37,7 +37,7 @@ void HTMLSummaryElement::activation_behavior(DOM::Event const&)
     if (parent->has_attribute(HTML::AttributeNames::open))
         parent->remove_attribute(HTML::AttributeNames::open);
     else
-        parent->set_attribute(HTML::AttributeNames::open, String {}).release_value_but_fixme_should_propagate_errors();
+        MUST(parent->set_attribute(HTML::AttributeNames::open, String {}));
 }
 
 // https://html.spec.whatwg.org/multipage/interactive-elements.html#summary-for-its-parent-details