Renovation time #155
Renovation time #155
Conversation
|
turns out |
|
As mentioned on Discord: can you please make sure your commits are atomic? E.g. combine a dependency update with the required fixes to our code to make it work. For your commit messages, please use the |
|
|
||
| test("Pages Rendered", () => { | ||
| mdFiles.forEach((file) => { | ||
| for (const file of mdFiles) { |
There was a problem hiding this comment.
Please write some notes in the commit message as to why these are best practices. The for loops feel like 6 of one, half a dozen of the other to me.
src/styles/global.css
Outdated
| "Segoe UI Symbol", "Noto Color Emoji"; | ||
| } | ||
|
|
||
| @keyframes marquee { |
There was a problem hiding this comment.
To expand on Jelle's comment about atomic commits - that means fixes like these should be squashed into the original commit that introduced the mistake, i.e. the tailwind v4 commit.
|
moved to #156 with atomic commits |
3 participants
Popping back over to do some cleanup. Moves onto astro 5 and tailwind 4, adds a few best practices in, moves to the more supported bun text lock, and does some small type fixes.