Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set eot status bit for ysf last packet #239

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

narspt
Copy link
Contributor

@narspt narspt commented Dec 8, 2023

I can't find real documentation about YSF protocol, however I did look at G4KLX code, like MMDVMHost, and I see he always set and rely on this bit to identify EOT:
https://github.com/g4klx/MMDVMHost/blob/f02cbcb141e53f1aeac5d0b6ee6dfc9d3b6e2b61/YSFControl.cpp#L915

MMDVMHost RX from XLX without the patch:

M: 2023-12-08 03:08:42.585 YSF, received network data from CT2HRB to DG-ID 0 at CT2HRB
M: 2023-12-08 03:08:45.345 YSF, network watchdog has expired, 1.4 seconds, 0% packet loss, BER: 0.0%
M: 2023-12-08 03:08:47.312 YSF, received network data from CT2HRB to DG-ID 0 at CT2HRB
M: 2023-12-08 03:08:50.628 YSF, network watchdog has expired, 1.9 seconds, 0% packet loss, BER: 0.0%

MMDVMHost RX from XLX after the patch:

M: 2023-12-08 03:30:18.097 YSF, received network data from CT2HRB to DG-ID 0 at CT2HRB
M: 2023-12-08 03:30:19.609 YSF, received network end of transmission from CT2HRB to DG-ID 0, 1.6 seconds, 0% packet loss, BER: 0.0%
M: 2023-12-08 03:30:23.130 YSF, received network data from CT2HRB to DG-ID 0 at CT2HRB
M: 2023-12-08 03:30:25.028 YSF, received network end of transmission from CT2HRB to DG-ID 0, 2.0 seconds, 0% packet loss, BER: 0.0%

@LX3JL LX3JL merged commit f0cc8dc into LX3JL:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants