Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to find_rail_file from RAILDIR as much as possible #86

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

eacharles
Copy link
Collaborator

The function find_rail_file will search the rail namespace for a file. This is more robust than using RAILDIR, because it will work even if some of the packages are installed from source and some are pip-installed.

@eacharles eacharles requested a review from sschmidt23 October 16, 2023 16:55
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (95c5b27) 100.00% compared to head (ec69e6d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested a couple of the notebooks to make sure that everything works ok and it does.

@eacharles eacharles merged commit e4f0d85 into main Oct 16, 2023
@eacharles eacharles deleted the issue/83/find_rail_file branch October 25, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants