-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last few tweaks to the quickstart & advanced-analysis tutorial #477
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #477 +/- ##
==========================================
- Coverage 63.90% 62.76% -1.14%
==========================================
Files 19 19
Lines 1568 1598 +30
==========================================
+ Hits 1002 1003 +1
- Misses 566 595 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was an issue where matches containg -1 indices could be added to the final catalog or array in the Matching object (not always the non-zero matches in the front!). In the end I realized that keeping the -1 is not really useful, so I removed it altogether and array of indices matched don't contain any -1 anymore, just the true matches (accounting for distance)
This PR will adjust the following two notebooks so they are ready to be released alongside the BTK paper:
quickstart
advanced-analysis
In
advanced-analysis
, I'm also tidying up the plots to be "paper-ready". Other todo items:advanced-analysis
or understand why they happen.In the end, when looking into the above to-do item I discovered some bugs in the matching procedure. So I'm fixing them here too.