Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last few tweaks to the quickstart & advanced-analysis tutorial #477

Merged
merged 32 commits into from
Apr 19, 2024

Conversation

ismael-mendoza
Copy link
Collaborator

@ismael-mendoza ismael-mendoza commented Feb 27, 2024

This PR will adjust the following two notebooks so they are ready to be released alongside the BTK paper:

  • quickstart
  • advanced-analysis

In advanced-analysis, I'm also tidying up the plots to be "paper-ready". Other todo items:

  • investigate some of the warnings raised by advanced-analysis or understand why they happen.

In the end, when looking into the above to-do item I discovered some bugs in the matching procedure. So I'm fixing them here too.

@ismael-mendoza ismael-mendoza self-assigned this Feb 27, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 24.07407% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 62.76%. Comparing base (180bf61) to head (cead309).

❗ Current head cead309 differs from pull request most recent head 655ce30. Consider uploading reports for the commit 655ce30 to get more accurate results

Files Patch % Lines
btk/match.py 33.33% 22 Missing ⚠️
btk/measure.py 13.33% 13 Missing ⚠️
btk/deblend.py 0.00% 5 Missing ⚠️
btk/plotting.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #477      +/-   ##
==========================================
- Coverage   63.90%   62.76%   -1.14%     
==========================================
  Files          19       19              
  Lines        1568     1598      +30     
==========================================
+ Hits         1002     1003       +1     
- Misses        566      595      +29     
Flag Coverage Δ
unittests 62.76% <24.07%> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ismael-mendoza ismael-mendoza marked this pull request as draft February 28, 2024 12:54
@ismael-mendoza ismael-mendoza linked an issue Feb 28, 2024 that may be closed by this pull request
8 tasks
ismael-mendoza and others added 18 commits February 29, 2024 15:43
There was an issue where matches containg -1 indices could be added to the final catalog or array in the Matching object (not always the non-zero matches in the front!). In the end I realized that keeping the -1 is not really useful, so I removed it altogether and array of indices matched don't contain any -1 anymore, just the true matches (accounting for distance)
@ismael-mendoza ismael-mendoza changed the base branch from main to dev April 17, 2024 20:37
@ismael-mendoza ismael-mendoza changed the title New latest tutorials Last few tweaks to the advanced-analysis tutorial Apr 17, 2024
@ismael-mendoza ismael-mendoza changed the title Last few tweaks to the advanced-analysis tutorial Last few tweaks to the quickstart & advanced-analysis tutorial Apr 17, 2024
@ismael-mendoza ismael-mendoza marked this pull request as ready for review April 19, 2024 18:33
@ismael-mendoza ismael-mendoza merged commit 115a0ae into dev Apr 19, 2024
4 checks passed
@ismael-mendoza ismael-mendoza deleted the new-latest-tutorials branch April 19, 2024 18:46
@ismael-mendoza ismael-mendoza removed a link to an issue Apr 26, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant