BaseInstance:Clone

[Kampfkarren]

Closes #143.

I like the idea behind how this is implemented, sort of an impl Clone feel. Looking for feedback on this design before moving forward.

Also thinking instead of a long if statement of every possible type, types implement their own :Clone functionality and if type(x) == "userdata" but typeof(x) ~= "userdata" then it attempts to call it.

Doesn't clone children yet, just want a comment about the design before going forward.

[coveralls]

Coverage decreased (-0.002%) to 97.985% when pulling 557fbe7 on Kampfkarren:clone into 03b70f7 on LPGhatguy:master.

[LPGhatguy]

This design seems pretty nifty!

We should be careful not to clone instances unless they're children, I noticed that the default clone implementation clones Instances!

[Kampfkarren]

I think I covered everything.

[LPGhatguy]

Cloning objects like Vector3 is kind of strange because they're immutable since you can't rely on their hashing behavior and their equality is overridden!

[Kampfkarren]

Vector3s don't hash.

> v3v = Instance.new("Vector3Value")
> v3v.Value = Vector3.new()
> x = {[v3v.Value] = true}
> print(x[v3v.Value])
nil

And their equality isn't overriden. That was in the test. They have custom __eq behaviors.

lemur/lib/types/Vector3.lua

Lines 60 to 62 in 5d4536e

	function metatable:__eq(other)
	return self.X == other.X and self.Y == other.Y and self.Z == other.Z
	end

Enums do which is why they're just an identity function.

[Kampfkarren]

luacov seems to think I didn't cover the if typeof(value) == "Instance" path even though I did?