Fix Channel Type decode #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
crisdut
force-pushed
the
fix/channel-type-decode
branch
from
32c19cc to
cee89a6
Compare
crisdut
force-pushed
the
fix/channel-type-decode
branch
from
cee89a6 to
233d73c
Compare
dr-orlovsky
requested changes
Mar 11, 2023
There was a problem hiding this comment.
The fix is invalid: it introduces more bugs. Pls see explanations why in LNP-WG/lightning_encoding#3 (comment)
Can you pls remove everything except added tests, use the branch from LNP-WG/lightning_encoding#5 and re-siubmit this PR?
I expect the tests will pass with the fix in lightning_encoding, and in lnp-core we need just #30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LNP-WG/lightning_encoding#3
It depends on LNP-WG/lightning_encoding#4