Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bool from verify functions' result #145

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

dr-orlovsky
Copy link
Member

Alternative to #144

I think this approach is better / safer - but it certainly is more complex

@dr-orlovsky dr-orlovsky added enhancement New feature or request *security* Issues affecting safety/security (include undefined behaviours) refactoring Refactoring of the existing code labels Oct 15, 2023
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Files Coverage Δ
commit_verify/src/lib.rs 100.0% <ø> (ø)
commit_verify/src/convolve.rs 83.3% <83.3%> (-3.3%) ⬇️
commit_verify/src/embed.rs 96.5% <91.3%> (-1.2%) ⬇️
commit_verify/src/commit.rs 75.4% <53.3%> (-5.4%) ⬇️

📢 Thoughts on this report? Let us know!.

Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this is using richer error types. This will help us a lot to handle reissuance issues our users will run into.

@dr-orlovsky dr-orlovsky marked this pull request as ready for review October 15, 2023 18:01
zoedberg
zoedberg previously approved these changes Oct 16, 2023
Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I agree this is a better approach than #144

@dr-orlovsky dr-orlovsky merged commit 387ed70 into master Oct 19, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Refactoring of the existing code *security* Issues affecting safety/security (include undefined behaviours)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants