Require result of verify functions to be used

[dr-orlovsky]

Will switch to just Result<(), VerifyError> in v0.11

[cryptoquick]

ACK

[codecov]

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
commit_verify/src/commit.rs	80.8% <ø> (ø)
commit_verify/src/convolve.rs	86.7% <ø> (ø)
commit_verify/src/embed.rs	97.7% <ø> (ø)
commit_verify/src/mpc/tree.rs	98.6% <100.0%> (+0.1%)	⬆️
commit_verify/src/mpc/atoms.rs	36.8% <0.0%> (-5.2%)	⬇️

📢 Thoughts on this report? Let us know!.

[zoedberg]

Build fails with:

error[E0063]: missing field `static_entropy` in initializer of `MultiSource`
   --> /home/zoe/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rgb-wallet-0.10.9/src/psbt/dbc.rs:119:22
    |
119 |         let source = mpc::MultiSource {
    |                      ^^^^^^^^^^^^^^^^ missing `static_entropy`

[dr-orlovsky]

@zoedberg you posted this to a wrong PR

But that PR is targeted for v0.11 so of course it won't compile with 0.10 stack

[zoedberg]

@dr-orlovsky Sorry, I haven't noticed that! Are you planning to apply this fix also to the 0.10 version?

[dr-orlovsky]

Which fix? From this PR or from the static entropy?

[zoedberg]

I'm confused. I was talking about this PR. I've patched commit_verify in rgb-lib like this:

commit_verify = { git = "https://github.com/LNP-BP/client_side_validation", branch = "fix/verify_not_used" }

and received the build error I posted here

[dr-orlovsky]

@zoedberg All right, I see. My bad. So I did start master for 0.11 - and did this PR on top of that changes coming from the PRs which were targeting v0.11 and were already merged into the master.

Thus, this PR must be against v0.10 branch and not master. Will fix that.

[dr-orlovsky]

@zoedberg done. Should work now.

[dr-orlovsky]

Anyway, my tests shows that all these changes are void, since rust enforces must_use only on the top-level type (which is result) and not onto boolean. If the boolean is unused, there still no compiler warning...

[zoedberg]

It builds and all our tests pass, thus ACK