-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for static entropy #140
Conversation
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but there are some warnings that may be addressed:
warning: unnecessary `pub(self)`
--> commit_verify/src/lib.rs:48:1
|
48 | pub(self) mod commit;
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: `#[warn(clippy::needless_pub_self)]` on by default
warning: unnecessary `pub(self)`
--> commit_verify/src/lib.rs:51:1
|
51 | pub(self) mod embed;
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
--> commit_verify/src/mpc/block.rs:123:27
|
123 | pub fn to_merkle_node(&self) -> MerkleNode {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `#[warn(clippy::wrong_self_convention)]` on by default
As said in BP-WG/bp-core#56 (comment) I think clippy should fail when there are warnings
This should help with unit testing, I would think |
@zoedberg already fixed in previously merged PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We have to target it for v0.11 since it breaks APIs - and there is no way of adding support for the feature without the API break