Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faad helper binaries to fix a crash when the decoder call fails. #771

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Update faad helper binaries to fix a crash when the decoder call fails. #771

merged 1 commit into from
Feb 23, 2022

Conversation

ralph-irving
Copy link
Contributor

Fixes crash when parsing malformed AAC file in faad.
Reported in slimserver-vendor issue LMS-Community/slimserver-vendor#95

Copy link
Member

@michaelherger michaelherger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you leave out the Mac build on purpose?

@mherger mherger merged commit e6ff277 into LMS-Community:public/8.3 Feb 23, 2022
@mherger
Copy link
Contributor

mherger commented Feb 23, 2022

Thanks a lot!

@ralph-irving
Copy link
Contributor Author

I thought you added the new macos faad in commit de3a671. If not, let me know and I'll submit it.

@michaelherger
Copy link
Member

I'm sorry for the misunderstanding. No worries: committed the binary you posted the other day on source forge, after removing i386.

@ralph-irving ralph-irving deleted the faad-updates branch February 23, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants