Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Midi Reversing #7606

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Midi Reversing #7606

wants to merge 3 commits into from

Conversation

regulus79
Copy link
Contributor

Adds the ability to reverse the selected midi notes in the PianoRoll.

The tool is located under the wrench icon in the PianoRoll and can also be triggered with Shift-R.

I am using the "back_to_start" pixmap as the icon since it seemed to fit, but perhaps in the future a dedicated icon could be made.

image

Copy link
Contributor

@szeli1 szeli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code and didn't find big issues, I will test soon.

src/gui/editors/PianoRoll.cpp Outdated Show resolved Hide resolved
@regulus79
Copy link
Contributor Author

Does anyone have any opinions on where the option should go in the dropdown menu? I put it at the end, but it may make sense to put it higher up.

Copy link
Contributor

@szeli1 szeli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes and couldn't find any problems. I approve this pull request.

@szeli1
Copy link
Contributor

szeli1 commented Nov 28, 2024

Does anyone have any opinions on where the option should go in the dropdown menu? I put it at the end, but it may make sense to put it higher up.

I think it is fine there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants