Refactor sample visualization implementation #7599
Open
+20
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakertooth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just doing a clean restart with the sample visualization. This implementation is only temporary and wont be keep in favor of the work at #7366 being done currently. This is just to fix some crashes involving loading large samples.
In doing this PR, I have noticed other issues as well currently in master. Some visualizations become completely glitched out or partially undrawn after zooming in all the way, which occurs near the middle of the sample usually. We should probably fix this in #7366 too (assuming it is a problem with our code).
Fixes #7576