Cleanup lmms_math.h
#7382
Open
Cleanup lmms_math.h
#7382
+50
−207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakertooth
reviewed
Jul 17, 2024
Co-authored-by: saker <[email protected]>
sakertooth
approved these changes
Jul 17, 2024
DomClark
reviewed
Jul 18, 2024
|
I would like to wait for #7380 before this PR. |
DomClark
approved these changes
Jul 21, 2024
Rossmaxx
commented
Jul 27, 2024
|
I have decided to clean up more mathematical stuff. |
DomClark
reviewed
Aug 10, 2024
sakertooth
reviewed
Aug 10, 2024
|
@DomClark we good for merge? I'm waiting for your nod. |
|
Did you plan to use |
|
No i said I'm not sure about the sign. There's chances negative values might be used. I don't wanna take much chances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up some legacy code from
lmms_math.h