-
-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about LADSPA problems #7267
Warn about LADSPA problems #7267
Conversation
Introduce a method which checks if a file that's loaded has the LADSPA controls saved in an old format that was written with a version before commit e99efd5. The method is run at the end so that problems in all file versions are detected. If a real upgrade was to be implemented it would have to run between `DataFile::upgrade_0_4_0_rc2` and `DataFile::upgrade_1_0_99`. See LMMS#5738 for more details.
Nice! Maybe the pop-up message should mention that you can try and save the project on a previous version of lmms like 1.1 or 1.2 ? At least it seem to have worked for Greshz-CoolSnip. |
@michaelgregorius thanks for this warning. Some initial thoughts:
From what I understand, this PR can be close (or if merged first, reverted) if we find a way to patch this behavior, which last I remember was held up in #5738 awaiting some feedback from @JohannesLorenz. |
Hi @tresf,
In this case the routine would have to collect a list of the names of all affected plugins and show them in the message. This should be feasible.
The comment was rather meant as a hint in that it is not a classical upgrade routine which moves data around but rather something that detects problems and warns the users about them. Muting the affected plugins could also be an option as it should be similar to the collection of the names as in that we'd have to find the parent that can be muted instead of finding the parent with the name. In that case a combination might be nice where the error message states names of the affected plugins that have been muted.
Exactly! Fixing this problem for good would be the better option than showing warning messages to the users. The latter might undermine the users trust in the application. |
I found a very large savefile from 2013, i.e. before toby's commit, which has stuff like this in the MMP:
Both the date and your code (because my savefile has a ladspacontrols tag which has attributes starting on "port" and are not "ports") imply that the warning should come? But I do not see it. |
@JohannesLorenz, can you please provide the test file? Or alternatively add code to dump the current state of It sounds like the file is fixed in between before it reaches |
Sorry, @michaelgregorius , I forgot! Will do soon . |
@michaelgregorius Sorry again. The warning indeed comes at the correct moments. I tested this with 10 files, in all cases, it was right. I just confused some filenames when I wrote that post. |
…ialLadspaPluginProblems Conflicts: * include/DataFile.h * src/core/DataFile.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning dialogue cannot harm in no way, so I approve this with only 1 optional comment.
Count the number of problematic LADSPA plugins and show it in the warning.
Introduce a method which checks if a file that's loaded has the LADSPA controls saved in an old format that was written with a version before commit e99efd5.
The method is run at the end so that problems in all file versions are detected. If a real upgrade was to be implemented it would have to run between
DataFile::upgrade_0_4_0_rc2
andDataFile::upgrade_1_0_99
.See #5738 for more details.