return the toString of invocation handler when calling toString on the proxy #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeb01
reviewed
Mar 21, 2017
| @@ -51,6 +53,11 @@ | |||
| @Override | |||
| public Object invoke(final Object proxy, final Method method, final Object[] args) throws Throwable | |||
| { | |||
| if (TO_STRING_METHOD_NAME.equals(method.getName())) | |||
There was a problem hiding this comment.
To be completely accurate, I think this check should also check the number of parameters to the call is zero. An overload of Foo.toString(long l) may need to be proxied.
There was a problem hiding this comment.
Good point. I'll add that.
mikeb01
reviewed
Mar 22, 2017
| @@ -53,7 +53,7 @@ | |||
| @Override | |||
| public Object invoke(final Object proxy, final Method method, final Object[] args) throws Throwable | |||
| { | |||
| if (TO_STRING_METHOD_NAME.equals(method.getName())) | |||
| if (TO_STRING_METHOD_NAME.equals(method.getName()) && args == null) | |||
| { | |||
There was a problem hiding this comment.
I think that you need to check args.length == 0. Could you include a unit test to verify?
There was a problem hiding this comment.
It is definitely null when there are no arguments, I've tested it and the JavaDoc states:
args - an array of objects containing the values of the arguments passed in the method invocation on the proxy instance, or null if interface method takes no arguments.
I'll work out a way of putting in a meaningful unit test to verify.
…ing toString on the proxy
|
@epickrram reviewed and is happy for me to merge. |
juddgaddie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #15