-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tupek/contact adjoint #1229
Open
tupek2
wants to merge
23
commits into
develop
Choose a base branch
from
tupek/contact_adjoint
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tupek/contact adjoint #1229
+370
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/style |
tupek2
force-pushed
the
tupek/contact_adjoint
branch
from
September 13, 2024 15:12
4bb9c5a
to
bad482e
Compare
tupek2
force-pushed
the
tupek/contact_adjoint
branch
from
September 27, 2024 16:05
2e52fda
to
5f42eaf
Compare
/style |
tupek2
force-pushed
the
tupek/contact_adjoint
branch
2 times, most recently
from
October 1, 2024 14:40
eb82e53
to
223474b
Compare
/style |
1 similar comment
/style |
samuelpmishLLNL
approved these changes
Nov 7, 2024
ebchin
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Delete copy
…nt states instead of generic mfem vectors.
tupek2
force-pushed
the
tupek/contact_adjoint
branch
from
November 22, 2024 18:44
f4b7a86
to
98e918e
Compare
/style |
1 similar comment
/style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract solid mechanics a bit to allow for contact jacobian corrections in the adjoint calculations. Gradient test is not super accurate, maybe ~20% off. Hopefully the analytic contact jacobians can fix this, or there is still some error in our adjoint calculations here?