Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tupek/contact adjoint #1229

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Tupek/contact adjoint #1229

wants to merge 23 commits into from

Conversation

tupek2
Copy link
Collaborator

@tupek2 tupek2 commented Sep 11, 2024

Abstract solid mechanics a bit to allow for contact jacobian corrections in the adjoint calculations. Gradient test is not super accurate, maybe ~20% off. Hopefully the analytic contact jacobians can fix this, or there is still some error in our adjoint calculations here?

@tupek2 tupek2 added the WIP Work in progress label Sep 11, 2024
@tupek2 tupek2 requested a review from ebchin September 11, 2024 03:43
@tupek2
Copy link
Collaborator Author

tupek2 commented Sep 11, 2024

/style

@tupek2
Copy link
Collaborator Author

tupek2 commented Sep 28, 2024

/style

@tupek2 tupek2 force-pushed the tupek/contact_adjoint branch 2 times, most recently from eb82e53 to 223474b Compare October 1, 2024 14:40
@tupek2
Copy link
Collaborator Author

tupek2 commented Oct 3, 2024

/style

1 similar comment
@tupek2
Copy link
Collaborator Author

tupek2 commented Oct 3, 2024

/style

@tupek2 tupek2 removed the WIP Work in progress label Oct 3, 2024
@tupek2 tupek2 added the ready for review Ready for active inspection by reviewers label Oct 9, 2024
btalamini
btalamini approved these changes Oct 25, 2024
Copy link
Member

@ebchin ebchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tupek2
Copy link
Collaborator Author

tupek2 commented Nov 22, 2024

/style

1 similar comment
@tupek2
Copy link
Collaborator Author

tupek2 commented Nov 22, 2024

/style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for active inspection by reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants