Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dense Matrix Unit Test Refactoring #170

Merged
merged 16 commits into from
Dec 28, 2020
Merged

Dense Matrix Unit Test Refactoring #170

merged 16 commits into from
Dec 28, 2020

Conversation

cameronrutherford
Copy link
Collaborator

Changes made in this PR are working towards closing #133.

Main changes are:

  • Enforcing specific matrix/vector types in implementation-specific unit tests
  • Refactoring of testMatrix.cpp to use template testing function to quickly test different memory spaces
  • Small changes to documentation and removal of commented out test

rcrutherford and others added 13 commits December 22, 2020 12:28
Removed unused funciton globalToLocalMap in matrixTests.hpp
cefb502
Implemented template testing function for all matrix tests.
12db66c
Adding myself as an author in modified files.
4015103
Added some documentation to matrixTests.hpp
6508a72
Removed unecessary casting in matrix test matrixTransAddToSymDenseMat…
2b93b7c 
…rixUpperTriangle
Enforcing specific vector type in implementation specific vector tests.
4060b72
Added enforcing of specific matrix type to implementation specific ma…
791db41 
…trix tests.
Removed commented out test that is not needed.
19bf163
removed erroneous #elif in place for #else.
fe1be4d
Enforced THROW_NULL_DEREF at end of implementation specific test func…
b35fe1c 
…tions when conversion of base class to derived class fails.
Removed warnings, updated comments and cleaned up code.
bccc7b7
Change matrix tests class names to match tested classes.
ef3892b
Modify tests file names to match corresponding src file names.
1737e66
pelesh
pelesh approved these changes Dec 24, 2020
View reviewed changes
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, full build matrix tests all pass. Make sure to squash commits upon merge.

@pelesh
Copy link
Collaborator

pelesh commented Dec 24, 2020

@cnpetra this is ready to merge. Dense matrix test classes names are changed per @nychiang suggestion.

@cnpetra cnpetra merged commit 423e67c into develop Dec 28, 2020
@cameronrutherford cameronrutherford mentioned this pull request Dec 29, 2020
Open
@cnpetra cnpetra deleted the rcrutherford-matrix-unit-tests-dev branch April 17, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelesh pelesh pelesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameronrutherford @pelesh @cnpetra