Encourage specific task schedules to reduce non-deterministic results #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encourages two different task schedules: all tasks executed by a worker thread and tasks with conflicting memory accesses scheduled to different threads.
Having these variants avoids non-deterministic classification and allows to distinguish task-centric and thread-centric data race analysis results.
Again: should we keep the variants close to the original by
*bnumbering?The codes at the moment use the new (OpenMP-5.0)
maskeddirective, which is only supported by newer compilers. A work-around for compilation with older compilers is to add-Dmasked=masterand let the preprocessor replace the clause name.