-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of enhanced and reduced connectivity #1316
Conversation
Examples are copied from http://visitusers.org/index.php?title=Representing_ghost_data |
Still needs cleanup in the code. @cyrush , what do you think of the API style--- passing in arrays of doubles for x, y, z coordinates of corners? |
The 3D grid has several domains made invisible so you can see the middle. I would have made them semi-transparent but I don't know how to do that domain-by-domain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agcapps Thanks for putting this together.
I want to void adding the std::vector based lerp functions to the public mesh blueprint interface. I am fine with them being private helpers to help implement the new example.
Also, I would prefer we don't change the base implementation of the explicit coords for braid. The prior implementation served as a simple C++ example that we could point folks at to help them learn how to create a coordset. But with the expanded version is much more complex, and leverages vectors of vectors -- folks might think all that is required to build a coordset.
Instead of unstructured topo, we want structured -- b/c that's the important case for reduced and enhanced (which also can included flipped logical indices across domains). That will be an important aspect of the example with respect to adjsets.
Changing to structured should be easy, you can replace the unstructured topo + connectivity with the structured topo def.
We should wire this up to the general examples driver. For that we will need a set of default params for the spec (opts).
See a few other suggestions (name changes, etc) in line, let me know if you have questions.
OK, makes sense.
Got it. I'll come up with an alternative.
Will change unstructured -> structured.
Thanks, I'll set that up.
|
@cyrush , I'd appreciate your further review. I think I got all the points you mentioned. |
@agcapps new changes look good. If you merge develop into this branch you will then be able to wire up the new examples to |
@Arlie-Capps I realized I may have pinged you on the old account :-( New changes look good. If you merge develop into this branch you will then be able to wire up the new examples to conduit::blueprint::mesh::examples:generate and add a simple test. If you like I can take care of this for you, I want to try o get a release ready soon. |
@cyrush , I think I've addressed what needs addressing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks Arlie!
Add an example of 2D and 3D multiblock grids with enhanced and reduced connectivity.
Example renderings by VisIt: