Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate symbol when compiling with intel oneapi #991

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fix duplicate symbol when compiling with intel oneapi #991

merged 1 commit into from
Jan 17, 2023

Conversation

white238
Copy link
Member

@adayton hit the following:

ld.lld: error: duplicate symbol: axom::quest::format_as(axom::quest::DistributedClosestPointRuntimePolicy)
>>> defined at DistributedClosestPoint.hpp:65 (lib/toss3_intel.oneapi.2022/axom/include/axom/quest/DistributedClosestPoint.hpp:65)
>>>            CMakeFiles/dir/__/io/ReadStl.cc.o:(axom::quest::format_as(axom::quest::DistributedClosestPointRuntimePolicy))
>>> defined at DistributedClosestPoint.hpp:65 (lib/toss3_intel.oneapi.2022/axom/include/axom/quest/DistributedClosestPoint.hpp:65)
>>>            CMakeFiles/dir/__/shapegen/ShapeFileStl.cxx.o:(.text._ZN4axom5quest9format_asENS0_36DistributedClosestPointRuntimePolicyE+0x0)

@white238 white238 added bug Something isn't working User Request Issues related to user requests labels Jan 11, 2023
kennyweiss
kennyweiss approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(and sorry for introducing it).

rhornung67
rhornung67 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Apparently, we've been benefiting from forgiving compilers.

@white238 white238 merged commit 20bfdf9 into develop Jan 17, 2023
@white238 white238 deleted the bugfix/white238/duplicate_symbol branch January 17, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhornung67 rhornung67 rhornung67 approved these changes

@kennyweiss kennyweiss kennyweiss approved these changes

@gunney1 gunney1 Awaiting requested review from gunney1

@bmhan12 bmhan12 Awaiting requested review from bmhan12

Assignees
No one assigned
Labels
bug Something isn't working User Request Issues related to user requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@white238 @kennyweiss @rhornung67