Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for RAJA and Umpire to Windows build #987

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Adds support for RAJA and Umpire to Windows build #987

merged 6 commits into from
Jan 5, 2023

Conversation

kennyweiss
Copy link
Member

Summary

@kennyweiss
Adds vcpkg ports for camp and RAJA
2e5b5bb 
And incorporates them into the axom (host-config generator) port.
@kennyweiss
Adds FOLDER property to inlet_test_utils target
7d1336d
@kennyweiss
Adds optional support for OpenMP to axom, raja and camp vcpkg p…
338d0da 
…orts

OpenMP is enabled by default for axom's port.
@kennyweiss
Adds vcpkg port for Umpire
556bb1e 
Using [email protected] due to a bug with zero-sized allocations in v2022.03.
@kennyweiss
Updates RELEASE-NOTES
e5a7b30
@kennyweiss kennyweiss added TPL Issues related to Axom's third party libraries User Request Issues related to user requests Windows Related to Windows development labels Jan 4, 2023
@kennyweiss kennyweiss self-assigned this Jan 4, 2023
agcapps
agcapps approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@agcapps agcapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, @kennyweiss .

rhornung67
rhornung67 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't work with vcpkg stuff. So my approval is minimally useful :-)

@kennyweiss
Copy link
Member Author

Passed the Windows TPL build CI: https://github.com/LLNL/axom/actions/runs/3842574364

@kennyweiss kennyweiss merged commit 3d77e46 into develop Jan 5, 2023
@kennyweiss kennyweiss deleted the feature/kweiss/improve-vcpkg branch January 5, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agcapps agcapps agcapps approved these changes

@rhornung67 rhornung67 rhornung67 approved these changes

@white238 white238 white238 approved these changes

@cyrush cyrush Awaiting requested review from cyrush

@gunney1 gunney1 Awaiting requested review from gunney1

@bmhan12 bmhan12 Awaiting requested review from bmhan12

Assignees

@kennyweiss kennyweiss

Labels
TPL Issues related to Axom's third party libraries User Request Issues related to user requests Windows Related to Windows development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install Axom with RAJA on Windows
4 participants
@kennyweiss @white238 @rhornung67 @agcapps