Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt on xlc+nvcc #492

Merged
merged 3 commits into from
Mar 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/thirdparty/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,6 @@ set(fmt_headers
fmt/chrono.h
fmt/color.h
fmt/locale.h
fmt/time.h
)

# Do not include the following source files in the headers list even
# though they are explicitly included by the headers. It will cause CMake
# to try to compile them in anything that depends on fmt outside
# of this directory due to CMake's file property scope (directory based)

set(fmt_headers_sources
fmt/format.cc
)

blt_add_library(NAME fmt
Expand Down
21 changes: 16 additions & 5 deletions src/thirdparty/fmt/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -1571,12 +1571,23 @@ class format_arg_store

friend class basic_format_args<Context>;

// AXOM PATCH: workaround for bug in combination of [email protected] + nvcc
// desc ended up being undefined, pulling out new type_encoding worked

// original:
// static constexpr unsigned long long desc =
// (is_packed ? detail::encode_types<Context, Args...>()
// : detail::is_unpacked_bit | num_args) |
// (num_named_args != 0
// ? static_cast<unsigned long long>(detail::has_named_args_bit)
// : 0);

static constexpr unsigned long long type_encoding = detail::encode_types<Context, Args...>();
white238 marked this conversation as resolved.
Show resolved Hide resolved
static constexpr unsigned long long desc =
(is_packed ? detail::encode_types<Context, Args...>()
: detail::is_unpacked_bit | num_args) |
(num_named_args != 0
? static_cast<unsigned long long>(detail::has_named_args_bit)
: 0);
(is_packed ? type_encoding : detail::is_unpacked_bit | num_args) |
(num_named_args != 0 ? static_cast<unsigned long long>(detail::has_named_args_bit) : 0);

// END AXOM PATCH

public:
format_arg_store(const Args&... args)
Expand Down
59 changes: 0 additions & 59 deletions src/thirdparty/fmt/format.cc

This file was deleted.

160 changes: 0 additions & 160 deletions src/thirdparty/fmt/time.h

This file was deleted.