-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gunney/point search comm filter #1349
Draft
gunney1
wants to merge
17
commits into
develop
Choose a base branch
from
feature/gunney/point-search-comm-filter
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method. The object bounding box from the BVH may have special values. We need the true bounding box. After computing the bounding box, gather it right away.
Not using the computed data yet.
gunney1
force-pushed
the
feature/gunney/point-search-comm-filter
branch
from
June 10, 2024 16:04
1769bc2
to
478fce1
Compare
If object "sphere" mesh doesn't extend to the poles, distance assuming a sphere is incorrect. This change gets it correct when the object mesh doesn't have the full latitude range.
gunney1
force-pushed
the
feature/gunney/point-search-comm-filter
branch
from
July 12, 2024 16:58
478fce1
to
30a4b72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out unproductive communication and searches in
DistributedClosestPoint
DistributedClosestPoint
so it doesn't require the object mesh to be a complete sphere in 3D. (The complete sphere has polar singularities that are not representative of typical meshes.)Motivation
The point search currently allows users to specify a threshold beyond which the user doesn't want to look. However, when this threshold is unspecified or large, the implementation can run unproductive searches. It can search and find distant points before searching more closely and discard the previous results. With this change, we examine the bounding boxes of domains before searching. We find a domain that is guaranteed to have points within a computable distance and exclude searching domains that cannot possibly beat that distance.
Approach
The check for unproductive searches is based on the min-max distance of object mesh partitions from a query mesh partition.
Skipping unproductive searches also removes the associated communications.