Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flux instead of srun on tioga #1011

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Use flux instead of srun on tioga #1011

merged 2 commits into from
Jan 24, 2023

Conversation

bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Jan 24, 2023

This PR:

kennyweiss and others added 2 commits January 23, 2023 22:15
@kennyweiss
Attempted workaround for temporarily faulty CI runner
718f1d0 
Per advice from LC, attempt to explicitly use `tioga10` runner
since something's wrong with the `tioga11` runner.
@bmhan12
Use flux instead of srun on tioga
7a058c3
@bmhan12 bmhan12 added bug Something isn't working CI Issues related to continuous integration labels Jan 24, 2023
rhornung67
rhornung67 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Nice work @bmhan12

kennyweiss
kennyweiss approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmhan12 -- hopefully this will get us past the current CI problem, and we can find a better solution in the meantime.

host-configs/[email protected]_hip.cmake
Comment on lines +44 to +46
set(MPIEXEC_EXECUTABLE "/usr/bin/flux" CACHE PATH "")

set(MPIEXEC_NUMPROC_FLAG "-n" CACHE STRING "")
set(MPIEXEC_NUMPROC_FLAG "mini;run;-n" CACHE STRING "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will get lost the next time we run build_tpls.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will get lost the next time we run build_tpls.py

I will do a follow-up PR with the spack fix for this host-config.
I think there are quite a few PR's that are ready to go, but just need this tioga fix for gitlab CI to pass.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmhan12 -- I agree that we should get something working as soon as possible.

Longer term, I think the MPIEXEC_NUMPROC_FLAG should allow for spaces (i.e. flux mini run) and we should make changes to blt/axom to support that.

@white238 pointed out a place yesterday where MPIEXEC_NUMPROC_FLAG likely needs to be quoted.
e.g.
https://github.com/LLNL/blt/blob/8c229991e65e7a9603c621b47cb3ba158bb7468c/cmake/BLTMacros.cmake#L904-L914

@bmhan12 bmhan12 merged commit 0705185 into develop Jan 24, 2023
@bmhan12 bmhan12 deleted the bugfix/han12/gitlabTioga branch January 24, 2023 17:24
@bmhan12 bmhan12 mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyweiss kennyweiss kennyweiss approved these changes

@rhornung67 rhornung67 rhornung67 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CI Issues related to continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmhan12 @kennyweiss @rhornung67