Reduce size of ArrayView returned by subspan
#1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size was allowing access of potentially invalid memory.
gunney1
added
bug
gunney1
requested review from
kennyweiss,
rhornung67,
publixsubfan,
agcapps and
bmhan12
rhornung67
reviewed
Jan 18, 2023
rhornung67
reviewed
Jan 18, 2023
kennyweiss
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Thanks for adding this @gunney1
Since you're already touching this function, it might be good to further improve the range checks and tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The over-large size was allowing access of potentially invalid memory by the
ArrayView. This can happen in the object returned byArrayView::subspan.ArrayViewby the offset amount, to make it NOT okay to access data past the end of the original view.ArrayView.I added the unit test because
subspanisn't used anywhere in the library. This change may affect application code that makes use of the buggy feature. The change is indicated in the release notes.