Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add new reduction valop / valloc interface to kernel #1799

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

johnbowen42
Copy link
Contributor

Summary

  • This PR is a (refactoring, bugfix, feature, something else)
  • It does the following (modify list as needed):
    • Modifies/refactors (class or method) (how?)
    • Fixes (issue number(s))
    • Adds (specific feature) at the request of (project or person)

Design review (for API changes or additions---delete if unneeded)

On (date), we reviewed this PR. We discussed the design ideas:

  1. First idea or goal
  2. Second idea
  3. Third idea

This PR implements 1. and 3. It leaves out 2. for the following reasons

  • (impractical)
  • (too big)
  • (not a good idea anyway)

@johnbowen42 johnbowen42 requested a review from a team March 25, 2025 21:33
@johnbowen42
Copy link
Contributor Author

@LLNL/raja-core It would be nice to get a preliminary review on this PR. I'm still working on the openmp implementation of this feature, but HIP and CUDA are passing the basic unit tests demonstrated in the PR

@artv3
Copy link
Member

artv3 commented Mar 26, 2025

@johnbowen42 , I took a look -- Overall its looking pretty good! My one comment is that we should add 2 lambda test just to verify that works as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants